Optional triangle vertex array normals generation #107
Conversation
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
==========================================
+ Coverage 63.29% 63.36% +0.06%
==========================================
Files 120 120
Lines 5882 5882
==========================================
+ Hits 3723 3727 +4
+ Misses 2159 2155 -4
Continue to review full report at Codecov.
|
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #107 +/- ##
==========================================
+ Coverage 63.29% 63.36% +0.06%
==========================================
Files 120 120
Lines 5882 5882
==========================================
+ Hits 3723 3727 +4
+ Misses 2159 2155 -4 ☔ View full report in Codecov by Sentry. |
Hi,
In our project, we don't need normals for raycasting and we don't use rigid body simulations. The computation of normals incur performance and memory usage overhead.
At first, we tried to copy all the stuff related to concave meshes, but we ended up in copying a lot of code for a tiny change.
I'm submitting this pull request to make the computation of normals option. Not sure it's the best way, but at least it raises the idea in the event you come up with something more suitable.